Use ExceptionTypeFilter to filter includes and excludes for retry policies
#35109
+11
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
the
in: core
Signed-off-by: Mengqi Xu <[email protected]>
sbrannen
added
type: task
sbrannen
changed the title
ExceptionTypeFilter to filter includes and excludes for retry policies
sbrannen
added a commit
that referenced
this pull request
Jul 3, 2025
This was referenced Jul 5, 2025
sbrannen
added a commit
that referenced
this pull request
Jul 5, 2025
Prior to this commit, ExceptionTypeFilter only supported matching against an exception type. However, most use cases involve matching against an exception instance. Moreover, every use case within the core Spring Framework uses ExceptionTypeFilter to match against concrete exception instances. This commit therefore introduces an overloaded match(Throwable) method in ExceptionTypeFilter in order to provide support for the most common use cases. See gh-35109 Closes gh-35160
sbrannen
added a commit
that referenced
this pull request
Jul 5, 2025
In commit 97522cf, I implemented a short-circuiting matching algorithm in DefaultRetryPolicy for includes and excludes, which was later copied to MethodRetrySpec. After we switched to using ExceptionTypeFilter, I realized that the matching algorithm in InstanceFilter (the superclass of ExceptionTypeFilter) does not exhibit the same short-circuiting characteristics. In light of that, this commit revises the matching algorithm in InstanceFilter to mirror the original short-circuiting algorithm in DefaultRetryPolicy. See gh-35058 See gh-35109 See gh-35160 Closes gh-35161
|
This has been merged into In addition, this PR inspired the following work.
Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's easy to filter
ThrowablewithExceptionTypeFilter. Otherwise, we would have to handle inclusions and exclusions everywhere.