Add builder support for SimpleClientHttpRequestFactory #35100
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to propose adding a Builder pattern to
SimpleClientHttpRequestFactory
in order to support fluent and immutable configuration of commonly used properties such as connectTimeout, readTimeout, proxy, and chunkSize.Current usage example (mutable setters):
Proposed usage example (fluent builder):
Motivation
The current mutable setter approach requires multiple separate calls and can lead to partially configured instances. A builder pattern enables fluent, thread-safe, and immutable configuration, improving readability and reducing errors. This approach is consistent with the design trends observed in several modern Spring APIs that have adopted or are adopting the builder pattern, helping to provide a more fluent and robust developer experience.
Proposal
Add a static nested Builder class with chainable setters and a build() method returning an immutable, fully configured SimpleClientHttpRequestFactory.