Apply unused io.spring.javaformat plugin
#35094
Closed
+219
−194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pankraz76
changed the title
io.spring.javaformat plugin
Pankraz76
force-pushed
the
pr-apply-lost-io.spring.javaformat
branch
from
d335324 to
6828305
Compare
spring-projects-issues
added
the
status: waiting-for-triage
Pankraz76
commented
Jun 22, 2025
| @@ -1,4 +1,4 @@ | |||
| org.gradle.caching=true | |||
| assertjVersion=3.27.3 | |||
| javaFormatVersion=0.0.43 | |||
There was a problem hiding this comment.
why does renovate not take care about this?
Signed-off-by: Vincent Potucek <[email protected]>
Pankraz76
force-pushed
the
pr-apply-lost-io.spring.javaformat
branch
from
6828305 to
abb3901
Compare
Pankraz76
commented
Jun 22, 2025
| } | ||
|
|
||
| repositories { | ||
| mavenCentral() | ||
| gradlePluginPortal() | ||
| } | ||
|
|
||
| tasks.named('compileJava') { |
There was a problem hiding this comment.
how to bind this properly, please? @bclozel
only the checkFormat goal is executed by default, but not the format.
bclozel
added
status: declined
|
As stated in previous PRs, please stop submitting cosmetic changes that apply your own opinion. |
|
Understood. Wondering why refer then on some plugin thats not used. seems like technical depth making contributors fix whitespaces. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
execute:
gradle formatbuild is not fixing itself, impose burden on contributor, despite having auto fix solution in place but not activated, leaking quality and compliance.