Skip to content

Update new-framework.adoc #35061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

DhruvTheDev1
Copy link
Contributor

  • Corrected xref paths to point to the correct locations.

- Corrected xref paths to point to the correct locations.

Signed-off-by: Dhruv <[email protected]>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 16, 2025
@bclozel
Copy link
Member

bclozel commented Jun 16, 2025

This is breaking the reference documentation generation. The links you are trying to fix are working fine on the live documentation (for example, the Coroutines link here).

Since the locations are already valid, I'm declining this PR.

@bclozel bclozel closed this Jun 16, 2025
@bclozel bclozel added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 16, 2025
@DhruvTheDev1
Copy link
Contributor Author

DhruvTheDev1 commented Jun 16, 2025

@bclozel Thank you for the clarification! I misunderstood how the xref links are resolved in the live docs. I appreciate the explanation and will be more careful with these in the future.

@sbrannen
Copy link
Member

@bclozel and I started typing at the same time, and he already covered the important parts.

But... I suppose you are trying the links from the view provided by GitHub:

https://github.com/spring-projects/spring-framework/blob/main/framework-docs/modules/ROOT/pages/web/webflux/new-framework.adoc

The links are not supposed to work in that view.

All that matters is that the links within the generated documentation work.

@DhruvTheDev1
Copy link
Contributor Author

@sbrannen Thank you for the explanation! I was indeed checking the links directly from GitHubs raw file view which I now understand is not the intended way to verify them.

Thank you for your guidance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants