Skip to content

Fix REPLY_CHANNEL header check in MessageHeaderAccessor #34949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix REPLY_CHANNEL header check in MessageHeaderAccessor #34949

wants to merge 1 commit into from

Conversation

remeio
Copy link
Contributor

@remeio remeio commented May 26, 2025

Fix gh-34881.

When header name is hannel and header value is 0.

headerAccessor.setHeader("hannel", 0);

It will throw IllegalArgumentException because replyChannel ends with hannel and header value is a integer.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label May 26, 2025
@sbrannen sbrannen added the in: messaging Issues in messaging modules (jms, messaging) label May 28, 2025
@rstoyanchev rstoyanchev self-assigned this May 29, 2025
@rstoyanchev rstoyanchev added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels May 29, 2025
@rstoyanchev rstoyanchev added this to the 6.2.8 milestone May 29, 2025
@rstoyanchev rstoyanchev changed the title Fix verify type for "REPLY_CHANNEL" header value Fix REPLY_CHANNEL header check in MessageHeaderAccessor May 29, 2025
@rstoyanchev rstoyanchev mentioned this pull request May 29, 2025
Closed
@sbrannen sbrannen assigned sbrannen and unassigned rstoyanchev Jun 2, 2025
@sbrannen sbrannen changed the title Fix REPLY_CHANNEL header check in MessageHeaderAccessor Fix REPLY_CHANNEL header check in MessageHeaderAccessor Jun 2, 2025
sbrannen added a commit that referenced this pull request Jun 2, 2025
@sbrannen
Polish contribution
f207c0e 
See gh-34949
@sbrannen sbrannen closed this in bbf61c7 Jun 2, 2025
@sbrannen
Copy link
Member

sbrannen commented Jun 2, 2025

This has been merged into 6.2.x and main in bbf61c7 and polished in f207c0e.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sbrannen sbrannen

Labels
in: messaging Issues in messaging modules (jms, messaging) type: bug A general bug
Projects
None yet
Milestone
6.2.8
Development

Successfully merging this pull request may close these issues.

Question about MessageHeaders.REPLY_CHANNEL.endsWith(headerName) usage in MessageHeaderAccessor#verifyType
4 participants
@remeio @sbrannen @rstoyanchev @spring-projects-issues