Introduce minimal retry functionality as a core framework feature #34716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
fmbenhassine
force-pushed
the
spring-retry
branch
from
92f257e to
baf3703
Compare
sbrannen
changed the title
sbrannen
added
the
in: core
sbrannen
requested changes
Apr 4, 2025
There was a problem hiding this comment.
Hi @fmbenhassine,
First and foremost, thanks for putting this PR together! 👍
I took a quick look, added a few comments, and asked a few questions (as food for thought).
And we will also discuss the proposal within the team.
Cheers,
Sam
spring-core/src/main/java/org/springframework/core/retry/RetryOperations.java
Outdated
Show resolved
Hide resolved
spring-core/src/main/java/org/springframework/core/retry/RetryPolicy.java
Outdated
Show resolved
Hide resolved
spring-core/src/main/java/org/springframework/core/retry/RetryPolicy.java
Outdated
Show resolved
Hide resolved
spring-core/src/main/java/org/springframework/core/retry/RetryOperations.java
Outdated
Show resolved
Hide resolved
spring-core/src/main/java/org/springframework/core/retry/RetryTemplate.java
Show resolved
Hide resolved
spring-core/src/main/java/org/springframework/core/retry/RetryTemplate.java
Outdated
Show resolved
Hide resolved
|
Thank you for the review, @sbrannen ! I added a couple of inline comments and I will update the PR accordingly. |
|
I updated the PR with the following changes:
I find this new version to be more coherent and consistent with other templates in terms of structure and API. Looking forward to the team's thoughts on this! |
fmbenhassine
force-pushed
the
spring-retry
branch
2 times, most recently
from
5facde5 to
b7a7ca6
Compare
artembilan
suggested changes
May 27, 2025
spring-core/src/main/java/org/springframework/core/retry/RetryException.java
Show resolved
Hide resolved
spring-core/src/main/java/org/springframework/core/retry/RetryCallback.java
Outdated
Show resolved
Hide resolved
spring-core/src/main/java/org/springframework/core/retry/RetryTemplate.java
Outdated
Show resolved
Hide resolved
spring-core/src/main/java/org/springframework/core/retry/RetryTemplate.java
Outdated
Show resolved
Hide resolved
spring-core/src/test/java/org/springframework/core/retry/RetryTemplateTests.java
Outdated
Show resolved
Hide resolved
spring-core/src/main/java/org/springframework/core/retry/support/MaxRetryAttemptsPolicy.java
Outdated
Show resolved
Hide resolved
spring-core/src/main/java/org/springframework/core/retry/support/PredicateRetryPolicy.java
Outdated
Show resolved
Hide resolved
spring-core/src/main/java/org/springframework/util/backoff/ExponentialBackOffPolicy.java
Outdated
Show resolved
Hide resolved
...g-core/src/test/java/org/springframework/core/retry/support/MaxRetryDurationPolicyTests.java
Outdated
Show resolved
Hide resolved
spring-core/src/main/java/org/springframework/core/retry/support/MaxRetryAttemptsPolicy.java
Show resolved
Hide resolved
sbrannen
reviewed
May 28, 2025
spring-core/src/main/java/org/springframework/core/retry/RetryExecution.java
Outdated
Show resolved
Hide resolved
|
Thank you for the review, @artembilan and @sbrannen ! I updated the PR accordingly and added a few comments. Please let me know if we need other updates. The build of the PR is failing for tests that are not related to this change set. |
artembilan
suggested changes
Jun 2, 2025
spring-core/src/main/java/org/springframework/core/retry/support/CompositeRetryListener.java
Outdated
Show resolved
Hide resolved
...g-core/src/test/java/org/springframework/core/retry/support/MaxRetryAttemptsPolicyTests.java
Outdated
Show resolved
Hide resolved
|
👋🏻 Joining the conversation here as Spring Cloud is an advanced user of Spring Retry, so we would be interested in how the functionality compares to the Spring Retry project. |
This comment was marked as outdated.
This comment was marked as outdated.
sbrannen
reviewed
Jun 4, 2025
spring-core/src/main/java/org/springframework/core/retry/support/PredicateRetryPolicy.java
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
sbrannen
requested changes
Jun 4, 2025
spring-core/src/main/java/org/springframework/core/retry/support/MaxRetryAttemptsPolicy.java
Outdated
Show resolved
Hide resolved
sbrannen
requested changes
Jun 4, 2025
spring-core/src/main/java/org/springframework/core/retry/RetryListener.java
Show resolved
Hide resolved
spring-core/src/main/java/org/springframework/core/retry/RetryListener.java
Outdated
Show resolved
Hide resolved
spring-core/src/main/java/org/springframework/core/retry/RetryTemplate.java
Show resolved
Hide resolved
spring-core/src/main/java/org/springframework/core/retry/RetryTemplate.java
Outdated
Show resolved
Hide resolved
jhoeller
added
type: enhancement
This commit introduces a minimal core retry feature. It is inspired by Spring Retry, but redesigned and trimmed to the bare minimum to cover most cases.
fmbenhassine
force-pushed
the
spring-retry
branch
from
b8454e2 to
3b68551
Compare
artembilan
suggested changes
Jun 4, 2025
spring-core/src/main/java/org/springframework/core/retry/support/CompositeRetryListener.java
Show resolved
Hide resolved
sbrannen
added a commit
that referenced
this pull request
Jun 5, 2025
This commit constitutes a first pass over the new core retry support. - Fix code and Javadoc formatting - Polish/fix Javadoc - Fix default FixedBackOff configuration in RetryTemplate - Consistent logging in RetryTemplate - Fix listener handling in CompositeRetryListener, allowing addListener() to work - Polish tests - Ensure RetryTemplateTests do not take over 30 seconds to execute See gh-34716
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a minimal core retry feature in Spring Framework. It is inspired by Spring Retry, but redesigned and trimmed to the bare minimum to cover most cases.
The main entry point is the
RetryTemplateclass, which is designed in a similar fashion to other templates provided by Spring. The package is minimal on purpose to keep its usage as simple as possible (see examples inRetryTemplateTests). It focuses only on stateless retries for now, but can be extended with other retry operations as well.