Add content disposition setter to ResponseEntity #33343
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
rfigueroa
force-pushed
the
reponse-entity-content-disposition
branch
from
6c7aa99 to
e6c76e7
Compare
rfigueroa
force-pushed
the
reponse-entity-content-disposition
branch
from
e6c76e7 to
9d6e720
Compare
| @@ -567,6 +577,12 @@ public BodyBuilder contentType(MediaType contentType) { | |||
| return this; | |||
| } | |||
|
|
|||
| @Override | |||
| public BodyBuilder contentDisposition(ContentDisposition contentDisposition) { | |||
| this.headers.setContentDisposition(contentDisposition); | |||
There was a problem hiding this comment.
This looks well written, Just a small comment
Consider adding a null check for the contentDisposition parameter. If null values are not allowed, you could throw an IllegalArgumentException
|
I understand the ask and thanks for providing a PR, but it is hard to argue why we should add this one and many others, + there is also |
sdeleuze
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #33342