Skip to content

Upgrade to Gradle 8.9 #33213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jul 14, 2024
@snicoll
Copy link
Member

snicoll commented Jul 14, 2024

@diguage thanks but we prefer to do those upgrades ourselves.

@snicoll snicoll closed this Jul 14, 2024
@snicoll snicoll added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jul 14, 2024
@diguage diguage deleted the upgrade-gradle branch July 14, 2024 09:27
@diguage
Copy link
Contributor Author

diguage commented Jul 14, 2024

@diguage thanks but we prefer to do those upgrades ourselves.

OK, as long as the problem is fixed, no matter who commits the code.

@snicoll
Copy link
Member

snicoll commented Jul 14, 2024

OK, as long as the problem is fixed, no matter who commits the code.

Hopefully, looking at the commit of #33214 and your proposal, you'll understand this isn't about who commits the code but to make sure to do things correctly.

@diguage
Copy link
Contributor Author

diguage commented Jul 15, 2024

OK, as long as the problem is fixed, no matter who commits the code.

I mean that I am glad that this problem has been fixed.

Hopefully, looking at the commit of #33214 and your proposal, you'll understand this isn't about who commits the code but to make sure to do things correctly.

I run the ./gradlew wrapper --gradle-version=8.9 and got the same code change as #33214 . But I refer to dfa6b4b, so I only modified the version number.

Thank you for your patience. Thank you again for fixing the problem.

diguage added a commit to diguage/asciidoctor-gradle-plugin that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants