Skip to content

Initial version with TX, Context Propagation and Observation #28156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

marcingrzejszczak
Copy link
Contributor

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 10, 2022
@marcingrzejszczak marcingrzejszczak marked this pull request as ready for review March 21, 2022 11:29
@marcingrzejszczak marcingrzejszczak force-pushed the tx_observability branch 2 times, most recently from 697de80 to 2ee4c00 Compare March 22, 2022 09:09
@bclozel bclozel self-assigned this Mar 22, 2022
@bclozel bclozel added the theme: observability An issue related to observability and tracing label Oct 3, 2022
@bclozel bclozel added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jan 23, 2023
@bclozel bclozel added this to the 6.1.x milestone Jan 23, 2023
@bclozel bclozel modified the milestones: 6.1.x, 6.x Backlog Oct 24, 2023
@bclozel bclozel added the status: declined A suggestion or change that we don't feel we should currently apply label Jan 9, 2024
@bclozel bclozel removed this from the 6.x Backlog milestone Jan 9, 2024
@bclozel
Copy link
Member

bclozel commented Jan 9, 2024

We have implemented lots of observability features already and I'm not sure we should go further ahead here with an observation per transaction call. Maybe this is similar to #30089 in the sense that we don't really need metrics/traces for this part? I'm not sure we need context propagation anyway as the transaction guarantee some context usage already.

I'm closing this issue for now and we'll revisit depending on the community requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply theme: observability An issue related to observability and tracing type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants