Initial version with TX, Context Propagation and Observation #28156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
...g-context-support/src/main/java/org/springframework/scheduling/quartz/SchedulerAccessor.java
Outdated
Show resolved
Hide resolved
...tx/src/main/java/org/springframework/transaction/support/DefaultTransactionTagsProvider.java
Outdated
Show resolved
Hide resolved
...main/java/org/springframework/transaction/support/ObservationPlatformTransactionManager.java
Outdated
Show resolved
Hide resolved
...main/java/org/springframework/transaction/support/ObservationPlatformTransactionManager.java
Show resolved
Hide resolved
spring-tx/src/main/java/org/springframework/transaction/support/TransactionObservation.java
Show resolved
Hide resolved
...main/java/org/springframework/transaction/support/ObservationPlatformTransactionManager.java
Outdated
Show resolved
Hide resolved
...-tx/src/main/java/org/springframework/transaction/support/TransactionObservationContext.java
Show resolved
Hide resolved
...tx/src/main/java/org/springframework/transaction/support/TransactionThreadLocalAccessor.java
Outdated
Show resolved
Hide resolved
spring-tx/src/main/java/org/springframework/transaction/support/TransactionTemplate.java
Outdated
Show resolved
Hide resolved
marcingrzejszczak
force-pushed
the
tx_observability
branch
2 times, most recently
from
697de80 to
2ee4c00
Compare
bclozel
added
the
theme: observability
bclozel
added
type: enhancement
after having talked to M. Paluch we came to the conslusion that such transaction propagation between threads can cause concurrency issues. We might corrupt / close / change the transaction in one thread and accidentaly break it in another one. If the problem that we're trying to solve is to allow transactions in tools like e.g. Resilience4j, we suggest creating a new transaction inside the lambda passed to such a tool.
marcingrzejszczak
force-pushed
the
tx_observability
branch
from
a4ac4a4 to
b195a19
Compare
marcingrzejszczak
force-pushed
the
tx_observability
branch
from
b195a19 to
2567af6
Compare
bclozel
added
the
status: declined
|
We have implemented lots of observability features already and I'm not sure we should go further ahead here with an observation per transaction call. Maybe this is similar to #30089 in the sense that we don't really need metrics/traces for this part? I'm not sure we need context propagation anyway as the transaction guarantee some context usage already. I'm closing this issue for now and we'll revisit depending on the community requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mp911de