Abort early in PropertyPlaceholderHelper if no placeholder exists #22870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
I've addressed this slightly differently, only doing the Thanks for raising this, in any case! |
jhoeller
added
in: core
sbrannen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I am currently working on spring-projects/spring-boot#16401 and investigate performance issues in the binding context. I noticed a small optimization opportunity in PropertyPlaceholderHelper if no placeholders exist. We can early out in those cases and thus save the allocations coming from the StringBuilder (and the HashSet).
To be fair: this is not a major performance bottleneck at all (there are ~5000 StringBuilder/HashSet allocations that we could save), but every little helps and who knows what other people might be doing with that class.
Cheers,
Christoph