Skip to content

Fixed nondetermistic tests in MappingRedisConverterUnitTests. #3242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixed nondetermistic tests in MappingRedisConverterUnitTests. #3242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions ...test/java/org/springframework/data/redis/core/convert/MappingRedisConverterUnitTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@
* @author Mark Paluch
* @author Golam Mazid Sajib
* @author John Blum
* @author Edwin Ing
*/
@ExtendWith(MockitoExtension.class)
class MappingRedisConverterUnitTests {
Expand Down Expand Up @@ -1080,7 +1081,15 @@ void writeShouldHonorCustomConversionOnNestedType() {
address.city = "unknown";
rand.address = address;

assertThat(write(rand)).containsEntry("address", "{\"city\":\"unknown\",\"country\":\"Tel'aran'rhiod\"}");
ObjectMapper mapper = new ObjectMapper();
assertThat(write(rand))
.hasEntrySatisfying("address", addr -> {
try {
assertThat(mapper.readTree(addr)).isEqualTo(mapper.readTree("{\"city\":\"unknown\",\"country\":\"Tel'aran'rhiod\"}"));
} catch (Exception e) {
throw new AssertionError("Error during JSON comparison: " + e.getMessage(), e);
}
});
}

@Test // DATAREDIS-425
Expand Down Expand Up @@ -1775,7 +1784,15 @@ void writeShouldWritePartialUpdatePathWithRegisteredCustomConversionCorrectly()

PartialUpdate<Person> update = new PartialUpdate<>("123", Person.class).set("address", address);

assertThat(write(update)).containsEntry("address", "{\"city\":\"unknown\",\"country\":\"Tel'aran'rhiod\"}");
ObjectMapper mapper = new ObjectMapper();
assertThat(write(update))
.hasEntrySatisfying("address", addr -> {
try {
assertThat(mapper.readTree(addr)).isEqualTo(mapper.readTree("{\"city\":\"unknown\",\"country\":\"Tel'aran'rhiod\"}"));
} catch (Exception e) {
throw new AssertionError("Error during JSON comparison: " + e.getMessage(), e);
}
});
}

@Test // DATAREDIS-471
Expand Down