Skip to content

Conversation

EdwinIngJ
Copy link

Fixes #3241

Summary

For the tests:

An ObjectMapper was used to parse the JSON string and expected JSON string, enabling the assertion to test for equality while being insensitive to property ordering.

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 19, 2025
@EdwinIngJ
Copy link
Author

I also found a similar issue with org.springframework.data.redis.core.convert.MappingRedisConverterUnitTests.writeShouldHonorCustomConversionOnRootType. I could update this PR with the fix or open a new PR.

@mp911de
Copy link
Member

mp911de commented Oct 21, 2025

Thank you for your pull request. Closing this one in favor of a simpler approach.

@mp911de mp911de added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: declined A suggestion or change that we don't feel we should currently apply

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nondeterministic Tests in MappingRedisConverterUnitTests

3 participants