-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Polishing #3452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Polishing #3452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Putting this on hold as we need to overhaul the |
52ee55f
to
61e6d36
Compare
mp911de
pushed a commit
that referenced
this pull request
Jan 31, 2025
Add missing `@FunctionalInterface` to Specification interfaces. `SpecificationUnitTests` shouldn't be `Serializable`. Closes #3452
mp911de
added a commit
that referenced
this pull request
Jan 31, 2025
Refine deprecation warnings. See #3452
mp911de
added a commit
that referenced
this pull request
Jan 31, 2025
Refine deprecation warnings. See #3452
mp911de
pushed a commit
that referenced
this pull request
Jan 31, 2025
Add missing `@FunctionalInterface` to Specification interfaces. `SpecificationUnitTests` shouldn't be `Serializable`. Closes #3452
Thank you for your contribution. That's merged, polished, and backported now. |
mp911de
pushed a commit
that referenced
this pull request
Mar 17, 2025
Add missing `@FunctionalInterface` to Specification interfaces. `SpecificationUnitTests` shouldn't be `Serializable`. Closes #3452
mp911de
pushed a commit
that referenced
this pull request
Apr 14, 2025
Add missing `@FunctionalInterface` to Specification interfaces. `SpecificationUnitTests` shouldn't be `Serializable`. Closes #3452
mp911de
pushed a commit
that referenced
this pull request
May 13, 2025
Add missing `@FunctionalInterface` to Specification interfaces. `SpecificationUnitTests` shouldn't be `Serializable`. Closes #3452
mp911de
pushed a commit
that referenced
this pull request
May 15, 2025
Add missing `@FunctionalInterface` to Specification interfaces. `SpecificationUnitTests` shouldn't be `Serializable`. Closes #3452
mp911de
pushed a commit
that referenced
this pull request
May 16, 2025
Add missing `@FunctionalInterface` to Specification interfaces. `SpecificationUnitTests` shouldn't be `Serializable`. Closes #3452
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specification
should be annotated with@FunctionalInterface
SpecificationUnitTests
shouldn't beSerializable