Skip to content

Upgrade to Hibernate Validator 6.0.2.Final #9969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

Upgrade to Hibernate Validator 6.0.2.Final #9969

wants to merge 9 commits into from

Conversation

rajadilipkolli
Copy link
Contributor

Hibernate Validator 6.0 Final comes with Bean Validation 2.0 support, this PR updates Hibernate Validator to latest version

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 7, 2017
@rajadilipkolli rajadilipkolli changed the title Update Hibernate Validator Upgrade to Hibernate Validator 6.0.1.Final Aug 7, 2017
@rajadilipkolli
Copy link
Contributor Author

@spring-issuemaster travis build failure is not related to this PR, can you restart it?

@wilkinsona
Copy link
Member

Thanks for the PR. I'm going to put this one on hold for now as there are still some decisions to be made about Hibernate Validator 6 that are being tracked by #9784.

@wilkinsona wilkinsona added the status: on-hold We can't start working on this issue yet label Aug 8, 2017
@rajadilipkolli rajadilipkolli changed the title Upgrade to Hibernate Validator 6.0.1.Final Upgrade to Hibernate Validator 6.0.2.Final Aug 29, 2017
@wilkinsona wilkinsona added this to the 2.0.0.M5 milestone Aug 29, 2017
@wilkinsona wilkinsona added priority: normal type: enhancement A general enhancement and removed status: on-hold We can't start working on this issue yet status: waiting-for-triage An issue we've not yet triaged labels Aug 29, 2017
@wilkinsona
Copy link
Member

wilkinsona commented Aug 29, 2017 •
edited
Loading

@rajadileepkolli Thanks again for the PR. It looks like we can proceed with the upgrade to Hibernate Validator 6 in M5. To make sure that no Hibernate Validator 5 or earlier dependencies creep in, can you please update the configuration of the enforcer plugin's banned dependencies?

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label Aug 29, 2017
@snicoll snicoll self-assigned this Sep 19, 2017
@snicoll snicoll removed the status: waiting-for-feedback We need additional information before we can continue label Sep 19, 2017
@snicoll snicoll closed this in a4a0eef Sep 19, 2017
snicoll added a commit that referenced this pull request Sep 19, 2017
@snicoll
Merge pull request #9969 from rajadilipkolli:patch-3
2ac6c10 
* pr/9969:
  Upgrade to Hibernate Validator 6.0.2.Final
@rajadilipkolli rajadilipkolli deleted the patch-3 branch September 19, 2017 15:46
@snicoll
Copy link
Member

snicoll commented Sep 19, 2017

That broke the build, I am looking at it

snicoll added a commit that referenced this pull request Sep 19, 2017
@snicoll
Upgrade to javax.validation 2.0.0.Final
9569768 
This should have been done in par with #9969

Closes gh-9784
snicoll added a commit that referenced this pull request Sep 19, 2017
@snicoll
Polish
8c0ffa3 
See gh-9969
snicoll added a commit that referenced this pull request Sep 19, 2017
@snicoll
Fix broken build
0f2d91c 
Hibernate Validator 6 has a slightly different structure for default
messages. This commit adapts our tests accordingly.

See gh-9969
@wilkinsona
Copy link
Member

The build is still broken. The Glassfish deployment test is failing because it's using the Validation API from the container rather than the deployed war. There's the first app server deployment test that runs. The others may well be broken too.

wilkinsona added a commit that referenced this pull request Sep 20, 2017
@wilkinsona
Use standard bean validation annotations that are new in 2.0
8ab12d9 
See gh-9969
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snicoll snicoll

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.0.0.M5
Development

Successfully merging this pull request may close these issues.
4 participants
@rajadilipkolli @wilkinsona @snicoll @spring-projects-issues