Skip to content

Change the application layout in documentation to show packaging by features. #9907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Change the application layout in documentation to show packaging by features. #9907

wants to merge 3 commits into from

Conversation

renjithgr
Copy link
Contributor

Fixes gh-9886.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 29, 2017
@wilkinsona wilkinsona self-requested a review July 30, 2017 07:07
wilkinsona
wilkinsona requested changes Jul 30, 2017
View reviewed changes
Copy link
Member

@wilkinsona wilkinsona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Unfortunately the indentation and ascii art for the tree doesn't look quite right now. Could you tidy it up a bit please? Perhaps you could use tree on the command line?

@renjithgr
Copy link
Contributor Author

Fixed it.

wilkinsona
wilkinsona requested changes Jul 30, 2017
View reviewed changes
Copy link
Member

@wilkinsona wilkinsona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. That's better, but it's still not quite right. Please see my two additional comments.

spring-boot-docs/src/main/asciidoc/using-spring-boot.adoc Outdated
+- web
+- CustomerController.java
+- order
| +- Order.java
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The | isn't needed in this line or in the following three

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed this too.

spring-boot-docs/src/main/asciidoc/using-spring-boot.adoc Outdated
@@ -358,18 +358,20 @@ Here is a typical layout:
----
com
+- example
+- myproject
+- myApplication
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package names are usually all lower case. Please change this back to myproject.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was silly of me. Fixed it. :)

@wilkinsona wilkinsona marked this as a duplicate of #9886 Jul 31, 2017
@wilkinsona wilkinsona mentioned this pull request Jul 31, 2017
Closed
@wilkinsona wilkinsona added priority: normal type: documentation A documentation update for: merge-with-amendments Needs some changes when we merge and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 31, 2017
@wilkinsona
Copy link
Member

Looks good now. Thank you.

@philwebb philwebb added this to the 2.0.0.M5 milestone Jul 31, 2017
@snicoll snicoll self-assigned this Sep 18, 2017
@snicoll snicoll removed the for: merge-with-amendments Needs some changes when we merge label Sep 18, 2017
snicoll pushed a commit that referenced this pull request Sep 18, 2017
@renjithgr @snicoll
Update application layout to show packaging by features
f948a46 
See gh-9907
@snicoll snicoll closed this in 474df8b Sep 18, 2017
snicoll added a commit that referenced this pull request Sep 18, 2017
@snicoll
Merge pull request #9907 from renjithgr:9886
c536af0 
* pr/9907:
  Polish "Update application layout to show packaging by features"
  Update application layout to show packaging by features
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilkinsona wilkinsona wilkinsona approved these changes

Assignees

@snicoll snicoll

Labels
type: documentation A documentation update
Projects
None yet
Milestone
2.0.0.M5
Development

Successfully merging this pull request may close these issues.
5 participants
@renjithgr @wilkinsona @snicoll @philwebb @spring-projects-issues