Skip to content

Add XMLUnit as a managed dependency and to the test starter #9709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add XMLUnit as a managed dependency and to the test starter #9709

wants to merge 2 commits into from

Conversation

andrew-j-cohen
Copy link
Contributor

Signed-off-by: Andrew Cohen [email protected]

@pivotal-issuemaster
Copy link

@andrew-j-cohen Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 9, 2017
@pivotal-issuemaster
Copy link

@andrew-j-cohen Thank you for signing the Contributor License Agreement!

wilkinsona
wilkinsona requested changes Jul 10, 2017
View reviewed changes
Copy link
Member

@wilkinsona wilkinsona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Please see my individual comments for a couple of suggested changes.

spring-boot-dependencies/pom.xml Outdated
@@ -2472,6 +2473,11 @@
<artifactId>xml-apis</artifactId>
<version>${xml-apis.version}</version>
</dependency>
<dependency>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this up a bit please? We try to keep the entries in alphabetical order using groupId first and then artifactId if required

spring-boot-starters/spring-boot-starter-test/pom.xml Outdated
@@ -40,6 +40,10 @@
<artifactId>junit</artifactId>
</dependency>
<dependency>
<groupId>org.xmlunit</groupId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this down a bit please? We try to keep the entries in alphabetical order using groupId first and then artifactId if required

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label Jul 10, 2017
@andrew-j-cohen
Copy link
Contributor Author

@wilkinsona Thanks for the feedback. I've put the dependencies in the proper order.

@wilkinsona
Copy link
Member

Thank you

@wilkinsona wilkinsona added for: team-attention An issue we'd like other members of the team to review type: enhancement A general enhancement and removed status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged labels Jul 12, 2017
@snicoll snicoll mentioned this pull request Sep 1, 2017
Closed
@snicoll snicoll changed the title Add XMLUnit as a managed dependency and to the test starter gh-9695 Add XMLUnit as a managed dependency and possibly to the test starter Sep 1, 2017
@philwebb philwebb added this to the 2.0.0.M5 milestone Sep 1, 2017
@wilkinsona wilkinsona removed the for: team-attention An issue we'd like other members of the team to review label Sep 1, 2017
@snicoll snicoll changed the title Add XMLUnit as a managed dependency and possibly to the test starter Add XMLUnit as a managed dependency and to the test starter Sep 18, 2017
@snicoll snicoll self-assigned this Sep 18, 2017
@snicoll snicoll closed this in 9c46dac Sep 18, 2017
snicoll added a commit that referenced this pull request Sep 18, 2017
@snicoll
Merge pull request #9709 from andrew-j-cohen:master
edfdae1 
* pr/9709:
  Add XMLUnit to spring-boot-starter-test
@wilkinsona
Copy link
Member

wilkinsona commented Sep 18, 2017 •
edited
Loading

I missed something earlier. We should use xmlunit2.version for the property as we have others projects (Spring Web Services for example) that still depend on xmlunit:xmlunit. As a result, the Platform has version properties for both.

We should also upgrade to 2.5 which is the latest version.

@wilkinsona wilkinsona reopened this Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilkinsona wilkinsona wilkinsona approved these changes

Assignees

@snicoll snicoll

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.0.0.M5
Development

Successfully merging this pull request may close these issues.
6 participants
@andrew-j-cohen @pivotal-issuemaster @wilkinsona @snicoll @philwebb @spring-projects-issues