Auto-configure Spring REST Docs to use REST Assured #9643
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
eddumelendez
force-pushed
the
gh-7228
branch
3 times, most recently
from
dd5435e to
b304d85
Compare
There was a problem hiding this comment.
In addition to the comment I left, I think it'd make sense to restructure the code a bit. I think I'd keep RestDocsAutoConfiguration, and then use inner classes for the MockMvc- and REST Assured-specific configuration.
What do you think, @eddumelendez? If my proposed changes make sense to you, do you have time to make them?
| @Configuration | ||
| @ConditionalOnClass({ RequestSpecification.class, RestAssuredRestDocumentation.class }) | ||
| @EnableConfigurationProperties | ||
| public class RestAssuredAutoConfiguration { |
There was a problem hiding this comment.
This doesn't feel quite right to me, particularly the name. It's not general purpose auto-configured for REST Assured so I think it might be better if it were named RestDocsRestAssuredAutoConfiguration.
|
@wilkinsona thanks for feedback. I have applied the changes and rebase my branch. Now, all checks passed ok. |
wilkinsona
changed the title
philwebb
added
type: enhancement
|
Thanks for yet another contribution, @eddumelendez. I've merged this into master. |
* gh-9643: Polish "Add auto-configuration for REST Docs with REST Assured" Add auto-configuration for REST Docs with REST Assured
See gh-7228