Add support for Spring WS auto WSDL/XSD exposure #9635
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
priority: normal
type: enhancement
|
Thanks @vpavic - I had a look and I was wondering if it wouldn't be a good thing to illustrate this feature in the existing sample? Some documentation update is probably also in order. Would you be willing to rework the PR? |
snicoll
added
the
status: waiting-for-feedback
|
Yes, I agree it would be a good idea to include this in the existing sample. I'll address that and the docs over the next day or two. Another point I wanted to discuss is whether we can simplify this to use a single location (and therefore a single configuration property) for both WSDLs and XSDs? The reason that led me to think in that direction is that WSLDs will typically have relative links to XSDs, so if you want the link to work locally you'll use something like |
vpavic
force-pushed
the
ws-wsdl-exposure
branch
from
abbf55d to
841db1c
Compare
|
I've update the PR with some documentation of the new feature. The sample is also updated, and while it still uses the generated WSDL, the XSD schema Any feedback on the idea of making it a single configuration property? |
| @Configuration | ||
| @EnableWs | ||
| protected static class WsConfiguration { | ||
|
|
||
| } | ||
|
|
||
| private static class WsdlDefinitionBeanFactoryPostProcessor |
There was a problem hiding this comment.
There seems to be a lot of shared functionality between WsdlDefinitionBeanFactoryPostProcessor and XsdSchemaBeanFactoryPostProcessor. I think it would be better to merge these two into one class, giving the varying parameters (property name, file extension, and bean class) as constructor arguments. ensureTrailingSlash and createBeanDefinition could then also move to said class.
|
@vpavic a single property works for me. We can certainly create another one if the need arise I guess? |
This commit adds support for auto-configuration of Spring WS automatic WSDL and XSD exposure i.e. registration of `WsdlDefinition` and `XsdDefinition` beans. The bean registration is triggered by configuring `spring.webservices.wsdl-locations` property which will search the provided locations for WSDL/XSD files and register appropriate beans.
vpavic
force-pushed
the
ws-wsdl-exposure
branch
from
841db1c to
b603f27
Compare
|
PR updated - there's a single property now, and a single |
snicoll
removed
the
status: waiting-for-feedback
This commit adds support for auto-configuration of Spring WS automatic WSDL and XSD exposure i.e. registration of `WsdlDefinition` and `XsdDefinition` beans. The bean registration is triggered by configuring `spring.webservices.wsdl-locations` property which will search the provided locations for WSDL/XSD files and register appropriate beans. See gh-9635
* pr/9635: Polish "Add support for Spring WS auto WSDL/XSD exposure" Add support for Spring WS auto WSDL/XSD exposure
|
Thanks @vpavic, this is now merged. |
This PR adds support for auto-configuration of Spring WS automatic WSDL and XSD exposure i.e. registration of
WsdlDefinitionandXsdDefinitionbeans. The bean registration is triggered by configuringspring.webservices.wsdl-locations/spring.webservices.xsd-locationsproperties which will search the provided locations for WSDL/XSD files and register appropriate beans.