support dynamic tags in @Counted and @Timed annotations #46007
+159
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks for the proposal. I think it would be better to support |
wilkinsona
added
status: waiting-for-feedback
doumdoum
force-pushed
the
add-meter-tag-to-counter
branch
2 times, most recently
from
697241a to
70f356e
Compare
doumdoum
changed the title
|
@wilkinsona i addressed your comments. |
spring-projects-issues
added
status: feedback-provided
wilkinsona
requested changes
Jun 25, 2025
There was a problem hiding this comment.
Thanks for the updates, @doumdoum. I've left a few comments for your consideration. The build is also failing at the moment. Please build your changes locally and make sure that the build is successful.
...a/org/springframework/boot/actuate/autoconfigure/tracing/SpelTagValueExpressionResolver.java
Outdated
Show resolved
Hide resolved
...a/org/springframework/boot/actuate/autoconfigure/tracing/SpelTagValueExpressionResolver.java
Outdated
Show resolved
Hide resolved
...g/springframework/boot/actuate/autoconfigure/metrics/SpelTagValueExpressionResolverTest.java
Outdated
Show resolved
Hide resolved
...a/org/springframework/boot/actuate/autoconfigure/tracing/SpelTagValueExpressionResolver.java
Outdated
Show resolved
Hide resolved
wilkinsona
added
status: waiting-for-feedback
doumdoum
force-pushed
the
add-meter-tag-to-counter
branch
from
ef646ef to
ab32879
Compare
wilkinsona
requested changes
Jun 26, 2025
...a/org/springframework/boot/actuate/autoconfigure/metrics/SpelTagValueExpressionResolver.java
Outdated
Show resolved
Hide resolved
.../springframework/boot/actuate/autoconfigure/metrics/SpelTagValueExpressionResolverTests.java
Outdated
Show resolved
Hide resolved
.../springframework/boot/actuate/autoconfigure/metrics/SpelTagValueExpressionResolverTests.java
Outdated
Show resolved
Hide resolved
...a/org/springframework/boot/actuate/autoconfigure/metrics/SpelTagValueExpressionResolver.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Dominique Villard <[email protected]>
…it so that it parses expressions only once Signed-off-by: Dominique Villard <[email protected]>
Signed-off-by: Dominique Villard <[email protected]>
Signed-off-by: Dominique Villard <[email protected]>
Signed-off-by: Dominique Villard <[email protected]>
Signed-off-by: Dominique Villard <[email protected]>
Signed-off-by: Dominique Villard <[email protected]>
doumdoum
force-pushed
the
add-meter-tag-to-counter
branch
from
bf5aa73 to
5ba8b83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns the
@Countedannotation with the@Timedannotation to support dynamic tags.