Skip to content

Polish #42075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Polish #42075

wants to merge 1 commit into from

Conversation

PiyalAhmed
Copy link
Contributor

Changes made:

  • GenerateAntoraPlaybook.java -> Removed unnecessary toString() call
  • ManagedDependencies.java -> Used isEmpty() for better readability
  • ConfigurationPropertiesReportEndpoint.java -> Resolved raw use of parameterized class

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 1, 2024
@philwebb
Copy link
Member

philwebb commented Sep 1, 2024

Thanks! I'm not sure we need HashMap<String, Object> change but the rest look good.

@philwebb philwebb added this to the 3.4.x milestone Sep 1, 2024
@philwebb philwebb added type: task A general task for: merge-with-amendments Needs some changes when we merge and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 1, 2024
@philwebb philwebb changed the title Improve code quality Polish Sep 2, 2024
philwebb pushed a commit that referenced this pull request Sep 2, 2024
@PiyalAhmed @philwebb
Polish
102fce3 
See gh-42075
@philwebb philwebb closed this in 53e7371 Sep 2, 2024
@philwebb philwebb modified the milestones: 3.4.x, 3.4.0-M3 Sep 2, 2024
@philwebb
Copy link
Member

philwebb commented Sep 2, 2024

Thanks @PiyalAhmed. I've removed the HashMap generics and merged the rest.

@PiyalAhmed
Copy link
Contributor Author

Thanks @PiyalAhmed. I've removed the HashMap generics and merged the rest.

Great, you're welcome!

@PiyalAhmed PiyalAhmed deleted the improve-code-quality branch September 2, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
for: merge-with-amendments Needs some changes when we merge type: task A general task
Projects
None yet
Milestone
3.4.0-M3
Development

Successfully merging this pull request may close these issues.
3 participants
@PiyalAhmed @philwebb @spring-projects-issues