Skip to content

Polish code to use 'switch' instead of 'if', remove unessary unboxing and redundant cast #40985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Polish code to use 'switch' instead of 'if', remove unessary unboxing and redundant cast #40985

wants to merge 3 commits into from

Conversation

asashour
Copy link
Contributor

@asashour asashour commented Jun 4, 2024 •
edited
Loading

This PR has the following changes:

  • Use switch instead of if
  • Remove unnecessary (un)boxing

@asashour
- Use switch instead of if
42fdd54 
- Remove unnecessary (ub)boxing
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 4, 2024
@mhalbritter mhalbritter changed the title Use switch instead of if Use switch instead of if Jun 4, 2024
@philwebb philwebb added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 4, 2024
@philwebb philwebb added this to the 3.4.x milestone Jun 4, 2024
@philwebb philwebb self-assigned this Jun 11, 2024
@philwebb philwebb modified the milestones: 3.4.x, 3.2.x Jun 11, 2024
@philwebb philwebb changed the title Use switch instead of if Polish code to use 'switch' instead of 'if', remove unessary unboxing and remote redundant cast Jun 11, 2024
@philwebb philwebb modified the milestones: 3.2.x, 3.2.7 Jun 11, 2024
@philwebb philwebb mentioned this pull request Jun 11, 2024
Closed
philwebb pushed a commit that referenced this pull request Jun 11, 2024
@asashour @philwebb
Use 'switch' instead of 'if'
2c5934d 
See gh-40985
philwebb added a commit that referenced this pull request Jun 11, 2024
@philwebb
Polish "Use 'switch' instead of 'if'"
a18cb37 
See gh-40985
philwebb pushed a commit that referenced this pull request Jun 11, 2024
@asashour @philwebb
Remove redundant cast
623c395 
See gh-40985
philwebb pushed a commit that referenced this pull request Jun 11, 2024
@asashour @philwebb
Prevent unnecessary unboxing
4f6509d 
See gh-40985
@philwebb philwebb closed this in ef99ce0 Jun 11, 2024
@philwebb
Copy link
Member

Thanks very much @asashour

philwebb pushed a commit that referenced this pull request Jun 11, 2024
@asashour @philwebb
Prevent unnecessary boxing
3a375ef 
See gh-40985
@asashour asashour deleted the enhancements branch June 12, 2024 05:49
@mhalbritter mhalbritter changed the title Polish code to use 'switch' instead of 'if', remove unessary unboxing and remote redundant cast Polish code to use 'switch' instead of 'if', remove unessary unboxing and redundant cast Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhalbritter mhalbritter mhalbritter left review comments

Assignees

@philwebb philwebb

Labels
type: task A general task
Projects
None yet
Milestone
3.2.7
Development

Successfully merging this pull request may close these issues.
4 participants
@asashour @philwebb @mhalbritter @spring-projects-issues