Replace lambda with method reference #40974
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
requested changes
Jun 3, 2024
...ure/src/main/java/org/springframework/boot/autoconfigure/flyway/FlywayAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...pring-boot-maven-plugin/src/main/java/org/springframework/boot/maven/ArtifactsLibraries.java
Outdated
Show resolved
Hide resolved
...boot-project/spring-boot/src/main/java/org/springframework/boot/ansi/AnsiPropertySource.java
Outdated
Show resolved
Hide resolved
...ect/spring-boot/src/main/java/org/springframework/boot/context/ApplicationPidFileWriter.java
Outdated
Show resolved
Hide resolved
...ect/spring-boot/src/main/java/org/springframework/boot/context/ApplicationPidFileWriter.java
Outdated
Show resolved
Hide resolved
wilkinsona
added
the
status: waiting-for-feedback
philwebb
added
type: task
|
When we merge this I think we should convert it into distinct commits for the method refs vs other stuff. |
|
In this case, this PR would contain the method reference, and I would create a new one for the other changes, thanks. |
wilkinsona
requested changes
Jun 4, 2024
There was a problem hiding this comment.
Thanks for the updates, @asashour. I just noticed one other change that I think would improve things a little. Please see the comments for details.
...moke-test-web-secure/src/test/java/smoketest/web/secure/SampleWebSecureApplicationTests.java
Outdated
Show resolved
Hide resolved
...-web-secure-jdbc/src/main/java/smoketest/web/secure/jdbc/SampleWebSecureJdbcApplication.java
Outdated
Show resolved
Hide resolved
...ecure-custom/src/main/java/smoketest/web/secure/custom/SampleWebSecureCustomApplication.java
Outdated
Show resolved
Hide resolved
...method-security/src/main/java/smoketest/security/method/SampleMethodSecurityApplication.java
Outdated
Show resolved
Hide resolved
...method-security/src/main/java/smoketest/security/method/SampleMethodSecurityApplication.java
Outdated
Show resolved
Hide resolved
...oke-tests/spring-boot-smoke-test-graphql/src/main/java/smoketest/graphql/SecurityConfig.java
Outdated
Show resolved
Hide resolved
...e-test-actuator/src/test/java/smoketest/actuator/ShutdownSampleActuatorApplicationTests.java
Outdated
Show resolved
Hide resolved
...ramework/boot/docs/data/sql/h2webconsole/springsecurity/DevProfileSecurityConfiguration.java
Outdated
Show resolved
Hide resolved
...ava/org/springframework/boot/devtools/autoconfigure/RemoteDevtoolsSecurityConfiguration.java
Outdated
Show resolved
Hide resolved
...amework/boot/autoconfigure/graphql/security/GraphQlWebMvcSecurityAutoConfigurationTests.java
Outdated
Show resolved
Hide resolved
|
If I may say something, there is an error for some time that |
philwebb
pushed a commit
that referenced
this pull request
Jun 11, 2024
philwebb
added a commit
that referenced
this pull request
Jun 11, 2024
philwebb
pushed a commit
that referenced
this pull request
Jun 11, 2024
philwebb
added a commit
that referenced
this pull request
Jun 11, 2024
|
Thanks @asashour |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces lambda with method reference whenever possible.