-
Notifications
You must be signed in to change notification settings - Fork 41.3k
Fix typos in method names and javadoc #40971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -141,7 +141,7 @@ private void assertHasClassesOrLocations(MergedContextConfiguration mergedConfig | |
boolean hasClasses = !ObjectUtils.isEmpty(mergedConfig.getClasses()); | ||
boolean hasLocations = !ObjectUtils.isEmpty(mergedConfig.getLocations()); | ||
Assert.state(hasClasses || hasLocations, | ||
() -> "No configuration classes or locations found in @SpringApplicationConfiguration. " | ||
() -> "No configuration classes or locations are found in @SpringApplicationConfiguration. " | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think "are" is needed here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Changes have been made, thank you for the feedback as always. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding "are" doesn't significantly improve clarity |
||
+ "For default configuration detection to work you need Spring 4.0.3 or better (found " | ||
+ SpringVersion.getVersion() + ")."); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is referring to the Testcontainers open source project. It should be singular.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the code accordingly. Thank you for the feedback.