Skip to content

Add org.hibernate.orm.jdbc.bind to sql logging group #40964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented May 31, 2024

It's reasonable to treat prepared statement parameters as part of sql.

See #36640 (comment)

It's reasonable to treat prepared statement parameters as part of sql.

See spring-projects#36640 (comment)
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 31, 2024
@wilkinsona
Copy link
Member

Thanks for the suggestion, but I don't think we should do this. If it were "reasonable to treat prepared statement parameters as part of sql", I think the Hibernate team would have included them in the org.hibernate.SQL logger that's already part of the sql logging group. I suspect that they're not included and have to be enabled separately as logging the actual parameters increases the risk of the logs including sensitive data. I think we should continue to align with that and require separate configuration to enable the logging of the actual parameter values.

@wilkinsona wilkinsona closed this May 31, 2024
@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels May 31, 2024
@quaff
Copy link
Contributor Author

quaff commented May 31, 2024

I suspect that they're not included and have to be enabled separately as logging the actual parameters increases the risk of the logs including sensitive data.

Fair enough, I didn't notice this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants