Skip to content

Conversation

@quaff
Copy link
Contributor

@quaff quaff commented Sep 2, 2021

No description provided.

@philwebb
Copy link
Member

philwebb commented Sep 2, 2021

I'm not sure that we should add additional properties here since we currently also use them in AbstractServletWebServerFactory where we can't easily add equivelent support.

We have an open issue (#20971) to deal with the same-site property, but we're currently blocked.

Flagging to see what the rest of the team think.

@philwebb philwebb added for: team-attention An issue we'd like other members of the team to review status: on-hold We can't start working on this issue yet labels Sep 2, 2021
@vpavic
Copy link
Contributor

vpavic commented Sep 2, 2021

IMO this again really boils down to #15047 (comment).

@philwebb
Copy link
Member

philwebb commented Sep 3, 2021

Thanks @vpavic, I had a feeling there was a better issue to link to but I couldn't find it. I think we should keep the customizer approach for now.

@philwebb philwebb closed this Sep 3, 2021
@philwebb philwebb added status: declined A suggestion or change that we don't feel we should currently apply and removed status: on-hold We can't start working on this issue yet for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged labels Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: declined A suggestion or change that we don't feel we should currently apply

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants