Provide an RSocketMessageHandlerCustomizer to allow customizing of the RSocketMessageHandler #21081
Conversation
|
@aartiguptaa Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@aartiguptaa Thank you for signing the Contributor License Agreement! |
|
@aartiguptaa Thanks for the pull request. I've left a few comments on it. In addition to those, the pull request is missing tests to verify that the customizers are being applied to the |
| @FunctionalInterface | ||
| public interface RSocketMessageHandlerCustomizer { | ||
|
|
||
| RSocketMessageHandler setRouteMatcher(RouteMatcher handler); |
There was a problem hiding this comment.
To be consistent with other customizers, the method shouldn't return anything but be void instead.
| @@ -36,17 +40,19 @@ | |||
| * @author Brian Clozel | |||
| * @since 2.2.0 | |||
| */ | |||
| @Configuration(proxyBeanMethods = false) | |||
| @ConditionalOnClass({ RSocketRequester.class, RSocketFactory.class, TcpServerTransport.class }) | |||
| @Configuration(proxyBeanMethods = true) | |||
There was a problem hiding this comment.
Is there a reason this was change to true?
| @ConditionalOnMissingBean(RSocketMessageHandler.class) | ||
| public RSocketMessageHandler messageHandler(RSocketStrategies rSocketStrategies, ObjectProvider<RSocketMessageHandlerCustomizer> customizers) { | ||
| RSocketMessageHandlerCustomizer rSocketMessageHandlerCustomizer = customizers.getIfAvailable(); | ||
| return rSocketMessageHandlerCustomizer.setRouteMatcher(rSocketStrategies.routeMatcher()); |
There was a problem hiding this comment.
It looks like messageHandler.setRSocketStrategies(rSocketStrategies) got removed as part of this change. We still want to do that and apply the customizers after that.
mbhave
added
the
status: waiting-for-feedback
wilkinsona
added
for: team-attention
wilkinsona
changed the title
|
@aartiguptaa Thank you for making your first contribution to Spring Boot. It has now been merged into master along with these amendments. |
Provide an RSocketMessageHandlerCustomizer to allow customizing of the RSocketMessageHandler
#20303