Upgrade to Testcontainers 1.14.0 #20936
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
Very very nice. Thank you @dreis2211! |
snicoll
added
type: dependency-upgrade
snicoll
pushed a commit
that referenced
this pull request
Apr 15, 2020
bsideup
reviewed
Apr 15, 2020
| .withStartupAttempts(5).withStartupTimeout(Duration.ofMinutes(10)) | ||
| .withNewBucket(BucketSettings.create(BUCKET_NAME)); | ||
| .withBucket(new BucketDefinition(BUCKET_NAME)); | ||
|
|
||
| private final ApplicationContextRunner contextRunner = new ApplicationContextRunner() |
There was a problem hiding this comment.
@snicoll FYI "spring.couchbase.connection-string:localhost:" + couchbase.getMappedPort(11210) isn't entirely correct.
Consider using "spring.couchbase.connection-string:" + couchbase.getConnectionString() (takes getContainerIpAddress() into consideration).
And, if more services are tested, the environment needs to be configured:
https://www.testcontainers.org/modules/databases/couchbase/#usage-example
There was a problem hiding this comment.
Ah that's good to know, I've polished that in 04544f9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR upgrades Testcontainers to version 1.14.0 and replaces the temporary copy of the
CouchbaseContaineras it should support SDK 3 now.Let me know what you think.
Cheers,
Christoph