Skip to content

Fix unused parameters #20911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix unused parameters #20911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...ot-cli/src/test/java/org/springframework/boot/cli/compiler/DependencyCustomizerTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ void setUp() {
MockitoAnnotations.initMocks(this);
given(this.resolver.getGroupId("spring-boot-starter-logging")).willReturn("org.springframework.boot");
given(this.resolver.getArtifactId("spring-boot-starter-logging")).willReturn("spring-boot-starter-logging");
given(this.resolver.getVersion("spring-boot-starter-logging")).willReturn("1.2.3");
this.moduleNode.addClass(this.classNode);
this.dependencyCustomizer = new DependencyCustomizer(new GroovyClassLoader(getClass().getClassLoader()),
this.moduleNode, new DependencyResolutionContext() {
Expand Down Expand Up @@ -184,6 +185,7 @@ private void assertGrabAnnotation(AnnotationNode annotationNode, String group, S
String classifier, String type, boolean transitive) {
assertThat(getMemberValue(annotationNode, "group")).isEqualTo(group);
assertThat(getMemberValue(annotationNode, "module")).isEqualTo(module);
assertThat(getMemberValue(annotationNode, "version")).isEqualTo(version);
if (type == null) {
assertThat(annotationNode.getMember("type")).isNull();
}
Expand Down
4 changes: 2 additions & 2 deletions ...pring-boot-loader-tools/src/main/java/org/springframework/boot/loader/tools/Packager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ private void addBootAttributes(Attributes attributes) {
addBootBootAttributesForRepackagingLayout(attributes, (RepackagingLayout) layout);
}
else {
addBootBootAttributesForPlainLayout(attributes, layout);
addBootBootAttributesForPlainLayout(attributes);
}
}

Expand All @@ -337,7 +337,7 @@ private void addBootBootAttributesForRepackagingLayout(Attributes attributes, Re
}
}

private void addBootBootAttributesForPlainLayout(Attributes attributes, Layout layout) {
private void addBootBootAttributesForPlainLayout(Attributes attributes) {
attributes.putValue(BOOT_CLASSES_ATTRIBUTE, getLayout().getClassesLocation());
putIfHasLength(attributes, BOOT_LIB_ATTRIBUTE, getLayout().getLibraryLocation("", LibraryScope.COMPILE));
}
Expand Down
4 changes: 2 additions & 2 deletions ...java/org/springframework/boot/web/embedded/undertow/UndertowReactiveWebServerFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ public WebServer getWebServer(org.springframework.http.server.reactive.HttpHandl
handler = UndertowCompressionConfigurer.configureCompression(getCompression(), handler);
Closeable closeable = null;
if (isAccessLogEnabled()) {
AccessLogHandlerConfiguration accessLogHandlerConfiguration = configureAccessLogHandler(builder, handler);
AccessLogHandlerConfiguration accessLogHandlerConfiguration = configureAccessLogHandler(handler);
closeable = accessLogHandlerConfiguration.closeable;
handler = accessLogHandlerConfiguration.accessLogHandler;
}
Expand Down Expand Up @@ -147,7 +147,7 @@ private Undertow.Builder createBuilder(int port) {
return builder;
}

private AccessLogHandlerConfiguration configureAccessLogHandler(Undertow.Builder builder, HttpHandler handler) {
private AccessLogHandlerConfiguration configureAccessLogHandler(HttpHandler handler) {
try {
createAccessLogDirectoryIfNecessary();
XnioWorker worker = createWorker();
Expand Down