Skip to content

Add reference to quickfixj spring boot starter #20819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

gevoulga
Copy link
Contributor

@gevoulga gevoulga commented Apr 3, 2020

A quickfixj spring boot starter, for the quickfixj library.
Quickfixj implements the FIX message exchange protocol.

A quickfixj spring boot starter, using the quickfixj, implementing the FIX message exchange protocol.
@pivotal-issuemaster
Copy link

@gevoulga Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@gevoulga Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 3, 2020
@snicoll
Copy link
Member

snicoll commented Apr 3, 2020

@gevoulga thanks for the suggestion. I had a quick look at the starter and found a number of issues that need to be reviewed before we reference it. Can you please have a look to those?

@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label Apr 3, 2020
@gevoulga
Copy link
Contributor Author

gevoulga commented Apr 3, 2020

@gevoulga thanks for the suggestion. I had a quick look at the starter and found a number of issues that need to be reviewed before we reference it. Can you please have a look to those?

@snicoll I've addressed the comments raised. Any followup comments are welcome.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Apr 3, 2020
@snicoll snicoll added type: documentation A documentation update and removed status: feedback-provided Feedback has been provided status: waiting-for-triage An issue we've not yet triaged labels Apr 5, 2020
@snicoll snicoll self-assigned this Apr 5, 2020
@snicoll snicoll added this to the 2.3.0.RC1 milestone Apr 5, 2020
@snicoll snicoll changed the title Added quickfixj spring boot starter Add reference to quickfixj spring boot starter Apr 5, 2020
snicoll pushed a commit that referenced this pull request Apr 5, 2020
@snicoll snicoll closed this in ed9cace Apr 5, 2020
@snicoll
Copy link
Member

snicoll commented Apr 5, 2020

Thanks for the quick follow-up @gevoulga and thank you for making your first contribution to Spring Boot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants