Skip to content

Enable users to provide custom time and datetime formats for MVC and WebFlux type conversion #18772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

knittl
Copy link
Contributor

@knittl knittl commented Oct 28, 2019

Extend WebFlux and WebMvc properties with timeFormat and dateTimeFormat
properties to allow users to customize format of LocalTime and
LocalDateTime instances.

This should add the missing functionality to #18511

@pivotal-issuemaster
Copy link

@knittl Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 28, 2019
@knittl knittl force-pushed the feature/18511-date-format-local-time branch from ac3ce48 to 7ae6dcc Compare October 29, 2019 07:45
Extend WebFlux and WebMvc properties with timeFormat and dateTimeFormat
properties to allow users to customize format of LocalTime and
LocalDateTime instances.
@knittl knittl force-pushed the feature/18511-date-format-local-time branch from 7ae6dcc to 9eac7c9 Compare October 29, 2019 08:28
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 2, 2019
@philwebb philwebb added this to the 2.3.x milestone Dec 2, 2019
@pivotal-issuemaster
Copy link

@knittl Thank you for signing the Contributor License Agreement!

@wilkinsona wilkinsona self-assigned this Apr 28, 2020
@wilkinsona wilkinsona modified the milestones: 2.3.x, 2.3.0.RC1 Apr 28, 2020
@wilkinsona wilkinsona changed the title Enable users to provide custom time and datetime formats Enable users to provide custom time and datetime formats for MVC and WebFlux type conversion Apr 28, 2020
wilkinsona pushed a commit that referenced this pull request Apr 29, 2020
Extend WebFlux and WebMvc properties with timeFormat and
dateTimeFormat properties to allow users to customize format of
LocalTime and LocalDateTime instances.

See gh-18772
@wilkinsona
Copy link
Member

Thank you very much for making your first contribution to Spring Boot, @knittl. I polished things a little bit in 95e5d4e, primarily to create a separate group for the format-related properties. For example, the MVC properties are now the following:

  • spring.mvc.format.date
  • spring.mvc.format.date-time
  • spring.mvc.format.time

@knittl
Copy link
Contributor Author

knittl commented Apr 29, 2020

My pleasure, thanks for polishing. I really like the newly introduced grouping of the properties!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants