Skip to content

Improvements on Thymeleaf reactive configuration #10507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

danielfernandez
Copy link
Contributor

Thymeleaf 3.0.8 (see #10319) added two new configuration parameters to ThymeleafReactiveViewResolver:

  • fullModeViewNames
  • chunkedModeViewNames

When a maximum chunk size is specified (in Spring Boot: spring.thymeleaf.reactive.max-chunk-size) these two new parameters allow to optionally fine-tune specifically which templates will be applied the specified maximum chunk size (and thus be executed in CHUNKED mode) and which won't.

See thymeleaf/thymeleaf-spring#159 for a detailed description of this new behaviour.

This PR modifies ThymeleafProperties and ThymeleafAutoConfiguration to add the possibility to configure these two new properties from the Spring Boot configuration mechanism. A couple of tests have been added too.

Additionally, there are two more commits included in the PR which perform a slight improvement in the doc of ThymeleafProperties and add a test for the spring.thymeleaf.reactive.max-chunk-size configuration property.

@danielfernandez danielfernandez force-pushed the improve_thymeleaf_reactive_conf branch from ef34a98 to 2f6e062 Compare October 5, 2017 21:17
@danielfernandez
Copy link
Contributor Author

Rebased and git push -f-ed branch after base code moved to spring-boot-project folder.

@bclozel bclozel merged commit e69a93b into spring-projects:master Oct 6, 2017
@bclozel
Copy link
Member

bclozel commented Oct 6, 2017

Thanks @danielfernandez !

@bclozel bclozel added priority: normal type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 6, 2017
@bclozel bclozel added this to the 2.0.0.M5 milestone Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants