Add tomcat-catalina-jmx-remote in Tomcat dependencies #10039
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
spring-boot-dependencies/pom.xml
Outdated
| @@ -1295,6 +1295,11 @@ | |||
| <version>${tomcat.version}</version> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.apache.tomcat</groupId> | |||
| <artifactId>tomcat-catalina-jmx-remote</artifactId> | |||
There was a problem hiding this comment.
Dependencies in this file are ordered. Could you please move it at the right place?
spring-boot-dependencies/pom.xml
Outdated
| @@ -1647,6 +1652,11 @@ | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.eclipse.jetty.websocket</groupId> | |||
| <artifactId>javax-websocket-client-impl</artifactId> | |||
|
What is the use case here? That would be the first catalina jar we would add and I don't know if we should do that. Either we add all tomcat jars or we restrict to the embedded case. It looks like we went with the latter for now. I am sure @wilkinsona knows more about the history |
snicoll
added
the
for: team-attention
|
@BlasD that branch is a bit weird. Can you please rebase cleanly from 1.5.x with a single commit and push force on your branch? Also I've noticed an = sign in your name:
|
|
@snicoll I use this to enable remote JMX with SpringBoot. Seeing we were manually set the version in our project, I thought it deserved to be moved to spring-boot. https://stackoverflow.com/questions/29412072/how-to-access-spring-boot-jmx-remotely I may update the PR with all catalina dependencies if it appeared relevant. |
|
I open #10045 which fix the log history and author (thanks for this). |
|
Duplicate of #10045 |
snicoll
added
status: duplicate
Add missing artifactId:
In jetty: javax-websocket-client-impl
in Tomcat: tomcat-catalina-jmx-remote