Fix Checkstyle plugin configuration. #5166
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit correctly sets the location of the checktyle configuration file. This is particularly important to allow the build-cache plugin to correctly factor in the hash of that config file in the build cache key. Remove properties that were not referenced or were implicit thanks to the maven checktyle <headerLocation> configuration. Remove reporting section that is unused. Auto-cherry-pick to 1.1.x Signed-off-by: Eric Bottard <[email protected]>
ericbottard
force-pushed
the
checkstyle-config
branch
from
c570d8e to
ff6e2bc
Compare
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit correctly sets the location of the checktyle configuration file. This is particularly important to allow the build-cache plugin to correctly factor in the hash of that config file in the build cache key.
Remove properties that were not referenced or were implicit thanks to the maven checktyle configuration.
Remove reporting section that is unused.
Auto-cherry-pick to 1.1.x