-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix: GH-3690, enhance RedisVectorStore with RedisVectorStoreBuilderCustomizer #3809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: GH-3690, enhance RedisVectorStore with RedisVectorStoreBuilderCustomizer #3809
Conversation
|
Thank you for keeping the words you shared earlier. I’ll also keep the words I said before. I appreciate your thoughtfulness. |
…rStoreBuilderCustomizer, add generic VectorStore.Builder customizer interface and Redis-specific customizer interface Signed-off-by: lanpf <[email protected]>
6d748cc to
1d8243f
Compare
Thanks for pointing that out! I've corrected the formatting - the issue reference |
|
@ilayaperumalg Could someone approve running CI for this PR? |
Signed-off-by: lanpf <[email protected]>
3afdb87 to
37085c5
Compare
@ilayaperumalg Apologies for the oversight—I didn’t have access to my work computer when submitting the PR and forgot to run the code formatting checks. I’ve now resolved the formatting issues using |
|
@lanpf No problem at all. thank you for the follow up and the contribution! |
|
getting back to this... sorry, catching up. |
Description
This PR introduces a generic extension point for customizing
VectorStore.BuilderviaVectorStoreBuilderCustomizerand fixes retrieval failures inRedisVectorStore.Background
Previously, when using
VectorStoreChatMemoryAdvisorwithRedisVectorStoreandinitialize-schema=true, metadata fields likeconversationId(used infilterExpression) weren't registered in the Redis schema. This occurred becauseRedisVectorStorePropertiesdidn't support settingmetadataFieldsduring auto-configuration, causing retrieval failures during similarity search.Related issue: #3690
Changes
VectorStoreBuilderCustomizer<T extends VectorStore.Builder<T>>interfaceRedisVectorStoreBuilderCustomizerVectorStoreBuilderCustomizer<RedisVectorStore.Builder>RedisVectorStoreAutoConfigurationRedisVectorStore.Builderas dependencyNew Customization Pattern
Developers can now customize metadata fields non-invasively:
Impact
initialize-schema=truefunctionalityRedisVectorStorewiringSpecial Thanks
🙌 To @Acacian for test contributions and valuable feedback.
Closes: #3690
Looking forward to your review!