Skip to content

Run PR Check GHA on every branch and allow it in Forks #3391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

filiphr
Copy link
Contributor

@filiphr filiphr commented May 30, 2025

This allows contributors to verify that everything is running fine before doing a PR

I saw that in 6df8484 there were some adjustments done to make sure that GHA are skipped on forks. I think that it could be useful if we adjust the pr-check GHA and allow it to run on every branch and for forks. Perhaps it needs a bit more dynamic one in order to avoid that it runs for Spring AI committers on every branch, or perhaps we can add a new action that would be like the pr-check, but it'll run when the repo owner is not spring-projects.

This allows contributors to verify that everything is running fine before doing a PR

Signed-off-by: Filip Hrisafov <[email protected]>
@filiphr filiphr force-pushed the enable-gha-for-forks branch from 0203195 to d9c3944 Compare May 30, 2025 08:24
@sobychacko
Copy link
Contributor

@filiphr We don't usually enable PR GH action in other projects on the forks. We usually expect the PR authors to make sure that everything is clean locally before issuing the PR. People might not even notice that the action ran on the forks. If you think there is a valid reason for enabling this, we can merge it, but I was curious if we need to do so. Thanks!

@filiphr
Copy link
Contributor Author

filiphr commented Jun 12, 2025

We usually expect the PR authors to make sure that everything is clean locally before issuing the PR

I agree with you about this one. I was doing some contributions in different areas and was switching between branches and of course I made some mistakes with the code format. So I enabled the Actions on my fork so I can check before doing a PR. However, I do understand your sentiment that it is good that people first run this locally.

People might not even notice that the action ran on the forks.

Actions are by default disabled when a fork is created. People have to explicitly enable them.


In any case, if you are doing it differently for other projects, then let's keep that as is and close this PR without merging it.

@sobychacko
Copy link
Contributor

@filiphr Thanks for the feedback. We will close this PR, but monitor the community to see if it's a persistent issue, and if so, we will revisit later. Thanks again!

@sobychacko sobychacko closed this Jun 12, 2025
@filiphr filiphr deleted the enable-gha-for-forks branch June 12, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants