Skip to content

Add support for PageSerializationMode.VIA_DTO (PagedModel) in PageJacksonModule #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

bruce-stewart
Copy link
Contributor

This pull request addresses issue #1144

Copy link
Collaborator

@OlgaMaciaszek OlgaMaciaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bruce-stewart, thanks for submitting the PR. Looks good. Please update the date in the license comments on top of all the java classes you've changed to -2025. Also, please add the @author tag with your full name and surname to the javadocs of the classes you've modified.

We now require the contributors to adhere to the DCO by signing-off their commits. Please follow these steps to amend your commits: https://github.com/spring-cloud/spring-cloud-openfeign/pull/1189/checks?check_run_id=41357021058.

@OlgaMaciaszek OlgaMaciaszek self-assigned this May 7, 2025
@OlgaMaciaszek OlgaMaciaszek added enhancement New feature or request in progress and removed waiting-for-triage labels May 7, 2025
bruce-stewart-altron and others added 6 commits May 8, 2025 09:25
Update license comments to 2025
…ksonModule

Add @author javadoc
Update license comments to 2025
Add support for PageSerializationMode.VIA_DTO (PagedModel) in PageJacksonModule

Signed-off-by: bruce-stewart <[email protected]>
@bruce-stewart
Copy link
Contributor Author

@OlgaMaciaszek Apologies for the clearly chaotic commit history on this - I have very little experience with contributing to Github projects, so my attempts at re-basing seem to be creating a lot of noise! I have updated the Copyright date and added my name as an author. I've been trying to clean up the sign-off commit comment, but am not having much success. Please let me know if there is something more that I should fix.

@OlgaMaciaszek
Copy link
Collaborator

Hi @bruce-stewart, unfortunately, the commit sign-off will be required (git commit --signoff). Usually, these steps work: https://github.com/spring-cloud/spring-cloud-openfeign/pull/1189/checks?check_run_id=41855140861. If there's an issue with it, since there not many changes, you could just create a new branch, copy in the changes and commit them with sign-off. Then push it and create a new pull request.

@bruce-stewart
Copy link
Contributor Author

Thanks @OlgaMaciaszek I'll do a new pull request

@bruce-stewart
Copy link
Contributor Author

I've created a new PR #1193

@bruce-stewart bruce-stewart deleted the pagedmodel-issue-1144 branch May 8, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenFeign client cannot correctly deserialize from stable page representation
4 participants