#263 Java routes API support for default filters #2191
Conversation
...way-server/src/test/java/org/springframework/cloud/gateway/test/sse/SseIntegrationTests.java
Show resolved
Hide resolved
...rc/test/java/org/springframework/cloud/gateway/test/websocket/WebSocketIntegrationTests.java
Show resolved
Hide resolved
...ay-server/src/main/java/org/springframework/cloud/gateway/config/LoadBalancerProperties.java
Outdated
Show resolved
Hide resolved
| public Map<String, Object> getMetadata() { | ||
| return Collections.unmodifiableMap(metadata); | ||
| } | ||
|
|
||
| public boolean isEnableDefaultFilter() { |
There was a problem hiding this comment.
This feels like additional functionality that is beyond the scope of simply supporting default filters via the java dsl. Please remove.
There was a problem hiding this comment.
route defined by java dsl use default filters is can incompatible change. especially when default filters has filter which can modify uri,if one request process by this filters more times,the url will not handled by any handlers.For this reason,i add a switch can control route use default filters or not.In future we may remove this.What's your suggestion？
There was a problem hiding this comment.
@spencergibb PTAL
There was a problem hiding this comment.
I still feel like it should be removed.
There was a problem hiding this comment.
ok,i will remove it soon
...loud-gateway-server/src/main/java/org/springframework/cloud/gateway/route/DefaultRoutes.java
Outdated
Show resolved
Hide resolved
...erver/src/main/java/org/springframework/cloud/gateway/route/RouteDefinitionRouteLocator.java
Outdated
Show resolved
Hide resolved
|
@spencergibb i hava modify this PR,please review again thanks. |
spencergibb
force-pushed
the
main
branch
2 times, most recently
from
1dc0e8a to
9efafe8
Compare
|
When will this PR be included in the release? |
Fixes gh-263