Skip to content

stripPrefix default to 1, link issue#2033 #2035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

KevinDeveloper
Copy link
Contributor

@KevinDeveloper KevinDeveloper commented Nov 11, 2020

link issue#2033

@KevinDeveloper KevinDeveloper force-pushed the lft_stripPrefix_default branch from 3b2d8f7 to 82c2264 Compare November 11, 2020 03:05
@KevinDeveloper KevinDeveloper changed the title set StripPrefix default to 1 StripPrefix default to 1, link issue#2033 Nov 11, 2020
@KevinDeveloper KevinDeveloper changed the title StripPrefix default to 1, link issue#2033 stripPrefix default to 1, link issue#2033 Nov 11, 2020
@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #2035 (b16ce09) into master (3e00fef) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2035      +/-   ##
============================================
- Coverage     77.11%   77.09%   -0.02%     
+ Complexity     1271     1269       -2     
============================================
  Files           164      164              
  Lines          4876     4877       +1     
  Branches        401      401              
============================================
  Hits           3760     3760              
  Misses          909      909              
- Partials        207      208       +1     
Impacted Files Coverage Δ Complexity Δ
...ork/cloud/gateway/route/builder/PredicateSpec.java 85.10% <ø> (ø) 32.00 <0.00> (ø)
...ilter/factory/StripPrefixGatewayFilterFactory.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
...eway/filter/factory/RetryGatewayFilterFactory.java 77.38% <0.00%> (-0.60%) 36.00% <0.00%> (-2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e00fef...b16ce09. Read the comment docs.

@spencergibb spencergibb linked an issue Mar 31, 2021 that may be closed by this pull request
@spencergibb
Copy link
Member

scheduled for 2021.0

@spencergibb spencergibb force-pushed the main branch 2 times, most recently from 1dc0e8a to 9efafe8 Compare November 8, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default StripPrefix to 1 instead of 0
3 participants