Remove dead code identified by Skylos#3408
Open
duriantaco wants to merge 2 commits intospotify:masterfrom
Open
Remove dead code identified by Skylos#3408duriantaco wants to merge 2 commits intospotify:masterfrom
duriantaco wants to merge 2 commits intospotify:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Luigi Team,
Description:
Remove dead code identified by Skylos static analysis:
scheduler.py: Replace unused variables (varkw,kwonlyargs,kwonlydefaults,ann) frominspect.getfullargspec()with_placeholdersprocess.py: Remove unused private function_server_already_running(defined but never called)db_task_history.py: Remove unused class constantCURRENT_SOURCE_VERSION(defined but never referenced)format.py: Remove unused methodOutputPipeProcessWrapper.writeLine(defined but never called)Motivation and Context:
Reduce dead code to improve maintainability. I use Luigi and I think it's really well maintained. Just wanted to do my part to clean things up a little bit. Each finding was identified using Skylos (https://github.com/duriantaco/skylos) static analysis with LLM-verified dead code detection, and independently verified by searching the entire codebase for references. No behavioral changes.
Have you tested this? If so, how?
Each removal was verified by searching the entire codebase (including tests, docs, and examples) for any references. No usages were found for any of the removed code.
Thanks!