Fix typos in Task.get_param_names: include_significant -> include_insignificant#3168
Open
nayopu wants to merge 1 commit intospotify:masterfrom
Open
Fix typos in Task.get_param_names: include_significant -> include_insignificant#3168nayopu wants to merge 1 commit intospotify:masterfrom
nayopu wants to merge 1 commit intospotify:masterfrom
Conversation
Fix typo in arguments of Task.get_param_names
nayopu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix typo
include_significant->include_insignificantinTask.get_param_namesDescription
Fix typos
include_significant->include_insignificantinTask.get_param_namesso the names match the actual behavior.Motivation and Context
No context.
The typos are inconsistent with the actual behavior.
Have you tested this? If so, how?
Not tested.
But there will be no side effects as just fixing typos and
include_significantonly appears in the fixed method.