Closed
Conversation
or which declared mitre_attack_id: [] but did not dynamically calculate mitre_attack_id. This should cause failures in contentctl validate until all content is fixed.
Collaborator
Author
|
Closing this PR - we will not take action on it at this time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A number of detection ymls are either missing the
mitre_attack_idkey altogether orhave declared
mitre_attack_id: [], but do not dynamically calculateannotations.mitre_attack.mitre_technique_idin the SPL of the detection (nor extract it from another field at runtime).Thi PR is marked as draft, and should fail contentctl validate, until this content is updated (if desired).
Missing tags can easily be found by searching for the string
DOES NOT DYANMICALLY CALCULATE MITRE_ATTACK_ID, PLEASE ADD APPROPRIATE HARDCODED MITRE ATTACK ID(S)