Skip to content

Tweaking attack_data links#3966

Merged
nasbench merged 3 commits intodevelopfrom
attack_data_url_tweaks
Mar 23, 2026
Merged

Tweaking attack_data links#3966
nasbench merged 3 commits intodevelopfrom
attack_data_url_tweaks

Conversation

@ljstella
Copy link
Contributor

Details

From a recent unit-testing job:

Attack Data Missing from all caches, but present at URL:
Attack Data   : https://raw.githubusercontent.com/splunk/attack_data/master/datasets/m365_copilot/copilot_prompt_logs.csv
  Valid Prefix: https://media.githubusercontent.com/media/splunk/attack_data/master/
Attack Data Missing from all caches, but present at URL:
Attack Data   : https://media.githubusercontent.com/media/splunk/attack_data/refs/heads/master/datasets/attack_techniques/T1558.004/powershell/windows-security-xml.log
  Valid Prefix: https://media.githubusercontent.com/media/splunk/attack_data/master/
Attack Data Missing from all caches, but present at URL:
Attack Data   : https://github.com/Splunk/attack_data/raw/master/datasets/attack_techniques/T1027.010/manual_b64_decode_pwsh/manual_b64_decode_pwsh.log
  Valid Prefix: https://media.githubusercontent.com/media/splunk/attack_data/master/
Attack Data Missing from all caches, but present at URL:
Attack Data   : https://github.com/Splunk/attack_data/raw/master/datasets/attack_techniques/T1082/sysinternals_pstools/sysinternals_pstools.log
  Valid Prefix: https://media.githubusercontent.com/media/splunk/attack_data/master/
Attack Data Missing from all caches, but present at URL:
Attack Data   : https://media.githubusercontent.com/media/splunk/attack_data/refs/heads/master/datasets/attack_techniques/T1090.003/windows_tor_client_execution/windows-sysmon.log
  Valid Prefix: https://media.githubusercontent.com/media/splunk/attack_data/master/

Checklist

  • Validate name matches <platform>_<mitre att&ck technique>_<short description> nomenclature
  • CI/CD jobs passed ✔️
  • Validated SPL logic.
  • Validated tags, description, and how to implement.
  • Verified references match analytic.
  • Confirm updates to lookups are handled properly.

Notes For Submitters and Reviewers

  • If you're submitting a PR from a fork, ensuring the box to allow updates from maintainers is checked will help speed up the process of getting it merged.
  • Checking the output of the build CI job when it fails will likely show an error about what is failing. You may have a very descriptive error of the specific field(s) in the specific file(s) that is causing an issue. In some cases, its also possible there is an issue with the YAML. Many of these can be caught with the pre-commit hooks if you set them up. These errors will be less descriptive as to what exactly is wrong, but will give you a column and row position in a specific file where the YAML processing breaks. If you're having trouble with this, feel free to add a comment to your PR tagging one of the maintainers and we'll be happy to help troubleshoot it.
  • Updates to existing lookup files can be tricky, because of how Splunk handles application updates and the differences between existing lookup files being updated vs new lookups. You can read more here but the short version is that any changes to lookup files need to bump the the date and version in the associated YAML file.

@ljstella ljstella added this to the v5.25.0 milestone Mar 18, 2026
@nasbench nasbench merged commit 0f08a8b into develop Mar 23, 2026
6 checks passed
@nasbench nasbench deleted the attack_data_url_tweaks branch March 23, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants