fix(build): Option 2 - "keep channels il-repacked"#452
Merged
Conversation
* Adds object flopper for experimental object uploads Implements a new mechanism for uploading objects to the server. * wip * pipe works * WIP * wip - refactors send pipeline
* Remove unused dependencies * remove unused package references * how's this * missed a bit
* di * di2 * Gergo's api changes
* refactor uploader for progress * progress * not so many decimal places * small tweak to RenderStreamProgress * fix unit tests * uploading data
* Add version id to ingestion query * and the sub * Add project & user ids * test
JR-Morgan
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #452 +/- ##
==========================================
+ Coverage 64.09% 69.88% +5.79%
==========================================
Files 289 343 +54
Lines 11843 14161 +2318
Branches 1137 1230 +93
==========================================
+ Hits 7591 9897 +2306
+ Misses 3936 3865 -71
- Partials 316 399 +83 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oguzhankoral
approved these changes
Mar 2, 2026
Member
Author
|
reverted as was accidently merged to main made a new pr: #453 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one of two mutually exclusive fixes for the various
TypeLoaderexceptions we currently seeing in various .NET Standard2.0 connectors.The other option is #451
This PR avoids having
System.Threading.Channelsas a dependency of the SDK by moving the channel usage into the ILRepackedSpeckle.SDK.DependenciesprojectThis aligns with previous serializer architecture.
However, due to needing to expose
ValueTaskandIAsyncEnumerableI'm now explicitly not repackingMicrosoft.BCL.AsyncInterfaces, and instead keeping the v9.0.4 as a regular dependency.Dependencies compared to
mainthis PR:.NET 8:
.NET Standard 2.0
Microsoft.BCL.AsyncInterfacestoSdk.Dependences(safe change)Microsoft.BCL.AsyncInterfacesto≥5.0.0to≥9.0.4(mostly safe change)The Advantages of this Option 2 over Option 1: