ensure channels is inside il repacked project#449
Closed
Conversation
Member
Author
|
closing in favour of #450 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current state of duckdev is broken, and we're unable to run it under Revit and Civil because of DLL problems loading Channels.
This is because Dim added a reference to Channels from the
Speckle.Sdkwhile we already have a reference from theSpeckle.Sdk.Dependenciesproject.For various reasons (that quite frankly, I'm quite unhappy with), we cannot use Channels from the SDK project. We have to keep usage of it inside the Sdk.Dependencies project.
This PR wrapps the channels usage in this "Repacked" channel so that the DiskStore can continue to use it fine.
This was the quickest fix I could think of that doesn't involve moving massive amounts of legacy code.
Note, this also means we add a dependency on
Microsoft.Bcl.AsyncInterfacesfor the .NETStandard2.0 target.This is ok, because we used to have it there anyway up-until recently, when I removed it because it was at the time not needed.