Skip to content

Fix commented config key typo #2844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

Fix commented config key typo #2844

merged 1 commit into from
May 14, 2025

Conversation

erikn69
Copy link
Contributor

@erikn69 erikn69 commented May 13, 2025 •
edited
Loading

Closes #2843

the correct key for this should just be "wildcard_permisson" without the permission. in front of it. If you uncomment this line and change to something custom (e.g. App\Models\CustomWildcardPermission::class) as recommended in the comment, it won't work

@drbyte
Copy link
Collaborator

drbyte commented May 14, 2025

Thanks!

@drbyte drbyte changed the title Fix #2843 Fix commented config key typo May 14, 2025
@drbyte drbyte merged commit ba3732e into spatie:main May 14, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coreytukios coreytukios coreytukios approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default config is wrong for custom WildcardPermission class
3 participants
@erikn69 @drbyte @coreytukios