Skip to content

Add shared Now Playing surfaces#289

Open
rbouteiller wants to merge 3 commits into
sozercan:mainfrom
rbouteiller:issue-260-now-playing-surfaces
Open

Add shared Now Playing surfaces#289
rbouteiller wants to merge 3 commits into
sozercan:mainfrom
rbouteiller:issue-260-now-playing-surfaces

Conversation

@rbouteiller

@rbouteiller rbouteiller commented Jun 6, 2026

Copy link
Copy Markdown

Summary

Implementation based on #260

  • Add a shared Now Playing Surfaces layer with canonical snapshots, command routing, generic surface settings, and coordinated lyrics demand/fetching.
  • Implement Music Island and Boring Notch compatibility as adapters on top of the shared layer instead of duplicating playback, lyrics, or WebView polling logic.
  • Harden the local bridge with loopback, Host/Origin validation, approval gating, bounded HTTP/WebSocket parsers, and focused regression coverage.

Reimplement:
#259
#210

Notes

  • Code was AI-generated and human-reviewed.

rbouteiller and others added 3 commits June 5, 2026 16:39
Introduce the shared now-playing snapshot, command routing, surface coordination, lyrics demand handling, Music Island adapter, and local Boring Notch bridge so auxiliary playback surfaces share one model.

Co-authored-by: Cursor <cursoragent@cursor.com>
Cover snapshot derivation, command routing, lyrics coordination, surface retries, Boring Notch codec compatibility, and bridge parser hardening while documenting the new surface architecture.

Co-authored-by: Cursor <cursoragent@cursor.com>
Use reported display notch geometry when available and fall back to a compact island without reserving fake notch space on regular displays.

Co-authored-by: Cursor <cursoragent@cursor.com>
Copilot AI review requested due to automatic review settings June 6, 2026 04:14
@rbouteiller

Copy link
Copy Markdown
Author

@sozercan let me know if you need anything else from my side.
This PR should be ready to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant