feat(composerjs): allow errors display for collectionField #1781
+58
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daric971
force-pushed
the
feat/conmposejs/collection-error-message
branch
4 times, most recently
from
702ecae to
cb55bbe
Compare
|
Hi @Daric971 ; can you rebase 4.x ? Thanks |
Daric971
force-pushed
the
feat/conmposejs/collection-error-message
branch
from
cb55bbe to
af444db
Compare
|
JS build is failing you might need to rebuild it |
Daric971
force-pushed
the
feat/conmposejs/collection-error-message
branch
from
af444db to
fd65106
Compare
VincentLanglet
approved these changes
Mar 3, 2025
|
WDYT @jordisala1991 |
|
@eerison Any opinion on this, I never used SonataPageBundle. |
eerison
reviewed
Sep 14, 2025
| * | ||
| * @param violation | ||
| */ | ||
| handleBlockCollectionErrors(violation) { |
There was a problem hiding this comment.
Did you copy this function from somewhere, or did you do it from scratch?
Hey @VincentLanglet Well I barely changed fronted code on pageBundle... looking the code it self, it's fine... but the we can not be sure without test 😐. As it is an old PR and no one else complain about it. Maybe it is an isolated case? I'm not sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because it has been noticed that form validation errors are not raised when dealing with collectionFields.
This PR provides a solution to this problem.
Closes #1770.
Changelog