Refactor token emitter #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kowczarz
approved these changes
Nov 27, 2025
kowczarz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an unfinished PR – don't merge without testing fully and adding OnStopObserving to stop the native Task
Motivation
We've had a customer that found it hard to use this module to get pushToStartTokens.
The listener triggered only on fresh app install, also there was no way to delay the listener subscription till after signin.
Changes suggested
I'd suggest revamping the code to use OnStartObserving, OnStopObserving fully, and having the listener always emit a token on subscription (not only when the native events happen)
I'd also suggest exposing current tokens as properties.