release 1.4.0 #1204
release 1.4.0 #1204
Conversation
WalkthroughThis change updates the parent Maven project version from Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (4)
jraft-extension/pom.xml (1)
4-8: Same parent-version verification as noted injraft-rheakv/pom.xmlEnsure
jraft-parent:1.4.0is resolvable; otherwise this module (and its sub-modules) will not compile.
No other issues spotted.jraft-test/pom.xml (1)
4-8: Parent version bump—see earlier commentBuild correctness depends on
jraft-parent:1.4.0being available.
Nothing else to flag for this POM.jraft-core/pom.xml (1)
4-8: Parent version consistency checkSame concern: verify
jraft-parent:1.4.0is published and contains the expected Java 8 compiler settings that all modules inherit.jraft-rheakv/rheakv-core/pom.xml (1)
4-8: Parent 1.4.0 availabilityInherited parent must be resolvable; see detailed verification script in the first POM review.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (10)
jraft-core/pom.xml(1 hunks)jraft-example/pom.xml(1 hunks)jraft-extension/bdb-log-storage-impl/pom.xml(1 hunks)jraft-extension/pom.xml(1 hunks)jraft-extension/rpc-grpc-impl/pom.xml(1 hunks)jraft-rheakv/pom.xml(1 hunks)jraft-rheakv/rheakv-core/pom.xml(1 hunks)jraft-rheakv/rheakv-pd/pom.xml(1 hunks)jraft-test/pom.xml(1 hunks)pom.xml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: test_rheakv_pd
- GitHub Check: test_rheakv_core
- GitHub Check: test_rpc_grpc_impl
- GitHub Check: test_jraft_core
- GitHub Check: sca
🔇 Additional comments (5)
jraft-extension/bdb-log-storage-impl/pom.xml (1)
7-7: Parent version bump looks goodThe module simply aligns with the new parent
1.4.0; no further issues spotted.jraft-extension/rpc-grpc-impl/pom.xml (1)
7-7: Parent version bump looks goodNo functional or build-time impact beyond inheriting the new parent.
jraft-rheakv/rheakv-pd/pom.xml (1)
7-7: Parent version bump looks goodConsistent with the rest of the multi-module build.
jraft-example/pom.xml (1)
8-8: Parent version bump looks goodNothing else changed; build behaviour is preserved.
pom.xml (1)
7-7: Root version updated – OKThe project has been correctly tagged as
1.4.0.
| <parent> | ||
| <artifactId>jraft-parent</artifactId> | ||
| <groupId>com.alipay.sofa</groupId> | ||
| <version>1.3.15.bugfix</version> | ||
| <version>1.4.0</version> | ||
| </parent> |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Confirm availability of jraft-parent:1.4.0 before merging
The build will fail for every module if com.alipay.sofa:jraft-parent:1.4.0 has not been published to your artifact repository / Maven Central.
Please verify the version exists and is publicly downloadable.
🏁 Script executed:
#!/bin/bash
# Verify that jraft-parent 1.4.0 is published on Maven Central
curl -s 'https://search.maven.org/solrsearch/select?q=g:%22com.alipay.sofa%22+AND+a:%22jraft-parent%22+AND+v:%221.4.0%22&rows=1&wt=json' \
| jq '.response.numFound' # expect: 1Length of output: 164
jraft-parent 1.4.0 not published to Maven Central
The Maven Central search returned 0 results for com.alipay.sofa:jraft-parent:1.4.0, so this parent POM isn’t available publicly. The build will fail unless you either:
- Publish
jraft-parent:1.4.0to your artifact repository (or Maven Central), or - Update the
<version>in jraft-rheakv/pom.xml (lines 4–8) to an already released parent version.
🤖 Prompt for AI Agents
In jraft-rheakv/pom.xml between lines 4 and 8, the parent POM version 1.4.0 for
jraft-parent is not available on Maven Central, causing build failures. To fix
this, either publish the jraft-parent version 1.4.0 to your artifact repository
or update the <version> tag to a previously released and publicly available
version of jraft-parent in the pom.xml file.
| <java.source.version>1.8</java.source.version> | ||
| <java.target.version>1.8</java.target.version> |
There was a problem hiding this comment.
Downgrading to Java 8 conflicts with existing Java 17-specific flags
maven-surefire-plugin (lines 365-367) still injects --add-opens … JVM options that are only recognised by Java 9+.
Running tests on JDK 8 will immediately fail with Unrecognized option: --add-opens.
Either keep the tool-chain at Java 17 or remove/conditionally add those module-open flags.
Suggested quick fix (revert to 17):
- <java.source.version>1.8</java.source.version>
- <java.target.version>1.8</java.target.version>
+ <java.source.version>17</java.source.version>
+ <java.target.version>17</java.target.version>If Java 8 is mandatory, also strip the --add-opens … from the surefire argLine and audit code for any Java 9+ APIs already in use.
🤖 Prompt for AI Agents
In pom.xml around lines 62 to 63, the Java source and target versions are set to
1.8, but the maven-surefire-plugin configuration at lines 365-367 still includes
Java 9+ specific JVM options like --add-opens, causing test failures on JDK 8.
To fix this, either revert the java.source.version and java.target.version back
to 17 to match the plugin settings, or if Java 8 must be used, remove or
conditionally exclude the --add-opens options from the surefire plugin's argLine
and verify no Java 9+ APIs are used in the codebase.
#1203
Summary by CodeRabbit