Skip to content

Add support for class getters and setters #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for class getters and setters #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion lib/create-script-decorator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,28 @@ export const createScript = function(app?: pc.Application) {
script.prototype[prop] = instance[prop];
}
}

// Add getters and setters to prototype
const prototypePropertyDescriptors = Object.getOwnPropertyDescriptors(
obj.prototype
);
for (const prop in prototypePropertyDescriptors) {
if (prop !== "constructor") {
const descriptors = prototypePropertyDescriptors[prop];
const { get, set } = descriptors;

if (get || set) {
const scriptDescriptor = {
get,
set,
enumerable: false,
configurable: true,
};

Object.defineProperty(script.prototype, prop, scriptDescriptor);
}
}
}

// Add static properties
for (let prop in obj) {
Expand Down Expand Up @@ -60,4 +82,4 @@ export class ScriptTypeBase {
* @memberof ScriptType
*/
enabled: boolean;
}
}